Shanghai is one of the most photogenic cities I've ever been to. Just walk around literally any part of it. Pudong is very "suburban" and representative of New China, Jingan is older but very, very modern in its lifestyle. The Former French Concession is the root/heart of all the foreign influence in the city. And anywhere outside of those areas is just very...Chinese. Which is to say infinitely photographable(is that a word?). It has the longest metro system in the world, I'd recommend you just hopping on the train and popping out at random stops to shoot for an hour or two.