The best bet is to have local contacts who understand where it's safe and where it is not. You can't just walk around anywhere and even in the good suburbs of Joburg, I didn't walk anywhere at night.
It is a fantastic country and the people are really great. I highly recommend you to go, but don't do anything the locals wouldn't do.
i agree with that absolutely.
I've been there - it was some 5 years ago) for 3 weeks with two friends (that's 3 white guys) one of them grew up in Johannesburg. His mom and brother were still there.
Do not follow guide books or internet rumors. You need - NEED - someone who is from there and knows the places and latest trends.
We've been in Pretoria in very nice neighborhood with bars and cool people, without our friend "guide" (he was busy) following the advice of a random guy in downtown Pretoria who was very cool. He started chatting us up on the street saying "what on earth are you lookin for here". Yes we were on the wrong spot at dusk. We had no trouble once we followed up his advice.
Similar in Johannesburg (three of us had no trouble but we did NOT go to dodgy neighborhoods, and business district Jo'burg was definitely dodgy that time) looking for adventure.
It's not a place where in big cities you can hang around shootin pics, it just isn't. You are in a nice spot, it might be you cross the road and "take a wrong turn" and in 2 minutes you are in the middle of gangland.
If you see a lot of white people, all ages, walking around you doin their business, you are probably fine. If they suddenly "disappear", you better catch up with them.
Capetown was much less hostile. Very relaxed downtown compared to busy Jo'burg. Tho it still has its nasty neighborhoods. But there's much more to do than just "climbing that rock" (which is nice, by the way). A lot of good party places, too. Same holds for Stellenbosch.
Anyway, going all the way to SA and missing out on nature is a sin.
We went around for 2 weeks from drakensberg to the kalahari and down to cape of good hope, it's a wonderful country. You can drive around quite efficiently, too. And cheaply.
PS as written above, whether you carry a leica a canonet or nothing at all visibly, if you're in the wrong spot you get mugged for what they think you might have and not for what you visibly carry with you. You ain't really safe in a car neither, especially if you stop for something.